Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBS-13913: Add SteamDB to the other databases whitelist #3460

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

reosarevok
Copy link
Member

Implement MBS-13913

Description

This adds support for SteamDB app pages, which for soundtrack DLC apps are often effectively albums.
For now, other SteamDB pages are locked - we can consider publisher for labels if there's interest later on, but I'm not sure it's even the right field and not worth working on yet.

Testing

Added a test to the suite.

Documenting

Made a doc change that should be transcluded on release.

This adds support for SteamDB app pages, which for soundtrack DLC
apps are often effectively albums.
For now, other SteamDB pages are locked - we can consider publisher
for labels if there's interest later on,
but I'm not sure it's even the right field and not worth working on yet.
Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works for me.

@reosarevok reosarevok merged commit e34dea0 into metabrainz:master Feb 4, 2025
2 checks passed
@reosarevok reosarevok deleted the MBS-13913 branch February 4, 2025 08:37
reosarevok added a commit that referenced this pull request Feb 4, 2025
* master:
  Update POT files using the production database
  MBS-13913: Add SteamDB to the other databases whitelist (#3460)
  MBS-13912: Show just "Bluesky" on sidebar for did:plc links (#3458)
  MBS-13911: Add 7digital links to the sidebar (#3459)
  MBS-13918: Link to docs from primary alias checkbox label (#3461)
  MBS-13921: Add Genie links to sidebar (#3462)
  MBS-13908: isolate artist credentials in edit diff (#3455)
  MBS-13035: Better "no results" message for CDTOC release search (#2916)
  MBS-12708: Report for lonely pseudo-releases (#2734)
  MBS-13770: Add new Admin approval/rejection votes
  Remove left-behind console.log
  MBS-13804: Also show where the review is on sidebar
  Remove unneeded regexes
  Move getFaviconClass out of render and simplify
  Sort special icons before per-site when editing links
  MBS-13804: Show review links as such on sidebar
  Change the blog icon to a more writing related one
reosarevok added a commit that referenced this pull request Feb 10, 2025
* beta:
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Chinese (Simplified Han script))
  Update translation files
  Update POT files using the production database
  Update translation files
  Merge pull request #3466 from dvirtz/MBS-13908
  Update POT files using the production database
  MBS-13913: Add SteamDB to the other databases whitelist (#3460)
  MBS-13912: Show just "Bluesky" on sidebar for did:plc links (#3458)
  MBS-13911: Add 7digital links to the sidebar (#3459)
  MBS-13918: Link to docs from primary alias checkbox label (#3461)
  MBS-13921: Add Genie links to sidebar (#3462)
  Translated using Weblate (Russian)
  Translated using Weblate (Russian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Polish)
  MBS-13908: isolate artist credentials in edit diff (#3455)
  MBS-13035: Better "no results" message for CDTOC release search (#2916)
  MBS-12708: Report for lonely pseudo-releases (#2734)
  Remove left-behind console.log
  MBS-13804: Also show where the review is on sidebar
  Remove unneeded regexes
  Move getFaviconClass out of render and simplify
  Sort special icons before per-site when editing links
  MBS-13804: Show review links as such on sidebar
  Change the blog icon to a more writing related one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants